Add LLaVA component to components.yml #236
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions
docker-compose.components.yml line 159 at r1 (raw file):
llava-detection-server: <<: *detection-component-base
This is not a component and should not extend from the component base.
docker-compose.components.yml line 167 at r1 (raw file):
memlock: -1 stack: 67108864 ports:
This is for exposing ports so that the server can be accessed externally to Docker. Since only your LLAVA component service needs to access it, I think this is unnecessary and should be removed.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @jrobble)
docker-compose.components.yml line 159 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
This is not a component and should not extend from the component base.
Done.
docker-compose.components.yml line 167 at r1 (raw file):
Previously, jrobble (Jeff Robble) wrote…
This is for exposing ports so that the server can be accessed externally to Docker. Since only your LLAVA component service needs to access it, I think this is unnecessary and should be removed.
Done.
|
Making a note to consider adding:
to address losing GPU connectivity when ollama unloads the model after inactivity. Issue mentioned here: ollama/ollama#6928 (comment) |
|
Change to |
2 participants
Issues:
Related PRs:
Please review our Contributor Guide.
This change is